Messages in this thread Patch in this message | | | Date | Tue, 25 Nov 2008 09:58:21 +0100 | From | Ingo Molnar <> | Subject | [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp() |
| |
Noticed the bug below while running our -Werror x86 randconfig build tests against tip/master. Please double check my control flow analysis.
Ingo
----------> From e5c3b90a18b73d593bba2a3f927a79469b6218d7 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Tue, 25 Nov 2008 09:47:28 +0100 Subject: [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit
this warning:
crypto/testmgr.c: In function ‘test_comp’: crypto/testmgr.c:829: warning: ‘ret’ may be used uninitialized in this function
triggers because GCC correctly notices that in the ctcount == 0 && dtcount != 0 input condition case this function can return an undefined value, if the second loop fails.
Remove the shadowed 'ret' variable from the second loop that was probably unintended.
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- crypto/testmgr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c index b828c6c..0cf0ae3 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -853,7 +853,7 @@ static int test_comp(struct crypto_comp *tfm, struct comp_testvec *ctemplate, } for (i = 0; i < dtcount; i++) { - int ilen, ret, dlen = COMP_BUF_SIZE; + int ilen, dlen = COMP_BUF_SIZE; memset(result, 0, sizeof (result)); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |