lkml.org 
[lkml]   [2008]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Display active jiffie timers in /proc/timer_list
    Joe,

    On Tue, 25 Nov 2008, Joe Korty wrote:
    > Add to /proc/timer_list a display of the active jiffie timers.
    >
    > Tested on i386 and x86_64, with 'less /proc/timer_list' and
    > through SysRq-Q.
    >
    > Signed-off-by: Joe Korty <joe.korty@ccur.com>
    >
    > Index: 2.6.28-rc6/kernel/timer.c
    > ===================================================================
    > --- 2.6.28-rc6.orig/kernel/timer.c 2008-11-25 11:59:07.000000000 -0500
    > +++ 2.6.28-rc6/kernel/timer.c 2008-11-25 13:49:05.000000000 -0500
    > @@ -36,6 +36,8 @@
    > #include <linux/syscalls.h>
    > #include <linux/delay.h>
    > #include <linux/tick.h>
    > +#include <linux/proc_fs.h>
    > +#include <linux/seq_file.h>
    > #include <linux/kallsyms.h>
    >
    > #include <asm/uaccess.h>
    > @@ -1568,6 +1570,87 @@
    > open_softirq(TIMER_SOFTIRQ, run_timer_softirq);
    > }
    >
    > +#if defined(CONFIG_PROC_FS) || defined(CONFIG_MAGIC_SYSRQ)

    This belongs into kernel/time/timer_list.c and there is no need to
    copy that code around.

    > +void print_cpu_jtimers(struct seq_file *m, int cpu)
    > +{
    > + int i;
    > + struct tvec_base *base = per_cpu(tvec_bases, cpu);
    > +
    > + SEQ_printf(m, "active jiffie timers:\n");
    > + spin_lock_irq(&base->lock);

    Yuck. We really do _NOT_ stop everything just to print timers. Check
    the hrtimer print code in timer_list.c

    > Index: 2.6.28-rc6/kernel/time/timer_list.c
    > ===================================================================
    > --- 2.6.28-rc6.orig/kernel/time/timer_list.c 2008-11-25 11:59:07.000000000 -0500
    > +++ 2.6.28-rc6/kernel/time/timer_list.c 2008-11-25 13:47:30.000000000 -0500
    > @@ -17,6 +17,7 @@
    > #include <linux/seq_file.h>
    > #include <linux/kallsyms.h>
    > #include <linux/tick.h>
    > +#include <linux/jiffies.h>
    >
    > #include <asm/uaccess.h>
    >
    > @@ -139,6 +140,7 @@
    > SEQ_printf(m, " clock %d:\n", i);
    > print_base(m, cpu_base->clock_base + i, now);
    > }
    > +

    random whitespace change

    > #define P(x) \
    > SEQ_printf(m, " .%-15s: %Lu\n", #x, \
    > (unsigned long long)(cpu_base->x))
    > @@ -176,9 +178,11 @@
    > P(last_jiffies);
    > P(next_jiffies);
    > P_ns(idle_expires);
    > - SEQ_printf(m, "jiffies: %Lu\n",
    > + SEQ_printf(m, "jiffies: %llu (0x%llx)\n",
    > + (unsigned long long)jiffies,
    > (unsigned long long)jiffies);

    The exact purpose of this change ?

    > @@ -286,7 +290,7 @@
    > {
    > struct proc_dir_entry *pe;
    >
    > - pe = proc_create("timer_list", 0644, NULL, &timer_list_fops);
    > + pe = proc_create("timer_list", 0444, NULL, &timer_list_fops);
    > if (!pe)
    > return -ENOMEM;
    > return 0;

    Correct, but unrelated $subject. Separate patch please.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2008-11-25 22:47    [W:0.026 / U:95.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site