Messages in this thread | | | Date | Sun, 23 Nov 2008 19:27:28 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [RFC -tip] x86: introduce X86_ assembly names macros to catch unbalanced declaration |
| |
[Ingo Molnar - Sun, Nov 23, 2008 at 05:22:57PM +0100] | | * Cyrill Gorcunov <gorcunov@gmail.com> wrote: | | > It's usefull to catch unbalanced or messed declarations of ENTRY and | > KPROBES. These macros would help a bit (at least I hope so). | > | > For example the following code would compile without problems | > | > X86_ENTRY(mcount) | > retq | > X86_END(mcount) | > | > But if you forget and mess the following form | > | > X86_ENTRY(mcount) | > retq | > END(mcount) | > | > X86_ENTRY(ftrace_caller) | > | > The assembler will issue the following message: | > Error: X86_ENTRY/KPROBE unbalanced or missed | | looks good - a very small detail: i'd suggest ENTRY_X86()/END_X86() - | because whoever is reading this portion of the code is amply aware of | the fact that this is the x86 tree - so the more important information | should come first. | | Ingo |
Will fix shortly :)
- Cyrill -
| |