lkml.org 
[lkml]   [2008]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] UBIFS: endian handling fixes and annotations
FromHarvey Harrison <>
DateSat, 22 Nov 2008 19:21:29 -0800
On Sat, 2008-11-22 at 20:27 +0100, Sebastian Andrzej Siewior wrote:
> * Artem Bityutskiy | 2008-11-21 19:19:24 [+0200]:
>
> > save_flags = mst->flags;
> >- mst->flags = cpu_to_le32(le32_to_cpu(mst->flags) | UBIFS_MST_RCVRY);
> >+ mst->flags |= cpu_to_le32(UBIFS_MST_RCVRY);
>
> another micro optimisation would be to use __constant_cpu_to_le32()
>

Nope, no difference, cpu_to_le32 does constant-detection these days and
so there ends up being no difference.

Harvey



\
 
 \ /
  Last update: 2008-11-23 04:43    [from the cache]
©2003-2010