[lkml]   [2008]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [spi-devel-general] [patch 05/14] mfd: PCAP2 driver
    On Saturday 22 November 2008, Daniel Ribeiro wrote:
    > Above comments are integrated on the attached patch.

    Not exactly:

    > --- a/drivers/mfd/Kconfig
    > +++ b/drivers/mfd/Kconfig
    > @@ -153,6 +153,13 @@ config MFD_WM8350_I2C
    >           I2C as the control interface.  Additional options must be
    >           selected to enable support for the functionality of the chip.
    > +config EZX_PCAP
    > +       bool "PCAP Support"
    > +       depends on PXA_EZX

    It only builds on one platform. Now, that may make sense if it's
    an ASIC currently used only on that platform; it's a "hardware"
    dependency. But it's not a necessary "software" dependency, no
    code here seems to rely on PXA hardware, or EZX hardware.

    One of the goals of getting drivers into mainline is to get rid
    of needless dependencies ... and thereby open the code up to
    many more developers. Some may do nothing more than cleanup;
    others will be doing API overhauls, which can be a PITA if you
    place needless build dependencies on your code.

    Strike that dependency, and depend instead on SPI_MASTER since
    that's the only dependency truly required by the build system.

    Or tell me I'm wrong, and there's really a reason this code must
    not even *build* on x86 systems.

    > +       help
    > +         This enables the PCAP ASIC present on EZX Phones. This is
    > +         needed for MMC, TouchScreen, Sound, USB, etc..
    > +
    >  endmenu

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2008-11-22 20:21    [W:0.038 / U:66.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site