lkml.org 
[lkml]   [2008]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 4/13 v7] PCI: remove unnecessary condition check in pci_restore_bars()
    Remove the unnecessary number of resources condition checks because
    the pci_update_resource() will check availability of the resources.

    Signed-off-by: Yu Zhao <yu.zhao@intel.com>

    ---
    drivers/pci/pci.c | 19 ++-----------------
    1 files changed, 2 insertions(+), 17 deletions(-)

    diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
    index c408be8..9d3f793 100644
    --- a/drivers/pci/pci.c
    +++ b/drivers/pci/pci.c
    @@ -360,24 +360,9 @@ pci_find_parent_resource(const struct pci_dev *dev, struct resource *res)
    static void
    pci_restore_bars(struct pci_dev *dev)
    {
    - int i, numres;
    -
    - switch (dev->hdr_type) {
    - case PCI_HEADER_TYPE_NORMAL:
    - numres = 6;
    - break;
    - case PCI_HEADER_TYPE_BRIDGE:
    - numres = 2;
    - break;
    - case PCI_HEADER_TYPE_CARDBUS:
    - numres = 1;
    - break;
    - default:
    - /* Should never get here, but just in case... */
    - return;
    - }
    + int i;

    - for (i = 0; i < numres; i++)
    + for (i = 0; i < PCI_BRIDGE_RESOURCES; i++)
    pci_update_resource(dev, i);
    }

    --
    1.5.6.4


    \
     
     \ /
      Last update: 2008-11-21 20:39    [W:0.021 / U:29.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site