lkml.org 
[lkml]   [2008]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] poll: allow f_op->poll to sleep, take #2
Miklos Szeredi wrote:
> On Sat, 22 Nov 2008, Tejun Heo wrote:
>> For both, I was trying to stay consistent with the environment. I
>> find mixed styles in close proximity much uglier than slightly
>> different but consistent style. Eh... Is the consensus checkpatch or
>> die?
>
> I think some common sense can be applied in these cases. For example
> a small amount of offending style in close proximity can be fixed as
> well, as long as it doesn't interfere too much with the readability of
> the patch.

Well, yeah, given that fs/select.c is not a very hot file. Introduced
inconsistencies are gonna stay there for a long time. The two issues
in this patch is minor and can be easily adjusted but in general I'm
not too sure whether always sticking with checkpatch is a good idea
especially on fairly cold areas. Anyways, I'll fix it up.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2008-11-21 18:35    [W:0.351 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site