lkml.org 
[lkml]   [2008]   [Nov]   [21]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 24/45] CacheFiles: Add a hook to write a single page of data to an inode [ver #41]
From Valdis.Kletnieks@vt ...
DateFri, 21 Nov 2008 12:15:35 -0500
On Fri, 21 Nov 2008 13:00:30 GMT, Jamie Lokier said:
> Couldn't we just skip the "wasted" comment lines and go to //-style
> comments, since it's been standard GCC for what, 13 years now?  And
> standard ANSI C for some 9 years...

The problem is that // style comments tend to encourage *really* short
comments, because we're already hitting col 80:
	current->whizbang = some_random_func(dev->wombats, 0); //vryshrtcmmnt
Making people use block comments encourages this:

	/*
	 * Since we're committed to at least 3 lines anyhow, take an
	 * extra line or two and explain why we're checking dev->wombats,
	 * rather than the more obvious proto->giraffe field....
	 */
	current->whizbang = some_random_func(dev->wombats, 0);
(And before you ask, trying to ban // comments on the right-hand of code, and
using // for block comments rather than /*... */ is the worst of both worlds.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-11-21 18:19    [from the cache]
©2003-2008