lkml.org 
[lkml]   [2008]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/10] x86: add check code for map/unmap_sg code

    * Joerg Roedel <joerg.roedel@amd.com> wrote:

    > + ret = ops->map_sg(hwdev, sg, nents, direction);

    stray double space in '= ops'.

    another very small detail:

    > + unsigned long flags;
    > + struct dma_debug_entry *entry;
    > + struct scatterlist *s;
    > + int i;

    please order them like this, similar to the include line:

    > + struct dma_debug_entry *entry;
    > + struct scatterlist *s;
    > + unsigned long flags;
    > + int i;

    that makes the whole variable section non-intrusive. (and also acts as
    a patch-conflict-reducer mechanism in the future - when variable
    definition lines get particularly long)

    (not a hard rule, exceptions are possible - grouping same-type fields
    together, etc.)

    Ingo


    \
     
     \ /
      Last update: 2008-11-21 18:13    [W:0.023 / U:60.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site