Messages in this thread | | | Date | Thu, 20 Nov 2008 13:01:21 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH] always assign userspace_addr |
| |
Anthony Liguori wrote: > > That's not how I read the code. I see: > >> >> static void kvm_free_physmem_slot(struct kvm_memory_slot *free, >> struct kvm_memory_slot *dont) >> { >> if (!dont || free->rmap != dont->rmap) >> vfree(free->rmap); > > And it's called as kvm_free_physmem_slot(&old, &new); > > new is assigned to old to start out with so old.rmap will equal new.rmap. >
Hm, if !npages we should just kvm_free_physmem_slot(&old, NULL).
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| |