Messages in this thread Patch in this message | | | Date | Fri, 21 Nov 2008 04:55:59 +0300 | From | Alexey Dobriyan <> | Subject | [PATCH] Fixup MODULE_DEVICE_TABLE(dmi, ...) |
| |
On Sat, Nov 15, 2008 at 11:14:52AM +0000, David Woodhouse wrote: > On Sat, 2008-11-15 at 02:41 +0300, Alexey Dobriyan wrote: > > How can this work, given that MODULE_DEVICE_TABLE line expands into > > > > extern const struct dmi_device_id __mod_dmi_device_table > > __attribute__ ((unused, alias("mbp_device_table"))); > > ^^^^^^ > > but there is no struct dmi_device_id, there is struct dmi_system_id? > > Interesting question ;) > > It actually looks like this... > > static struct dmi_system_id __initdata mbp_device_table[] = { > ... > }; > > extern const struct dmi_device_id __mod_dmi_device_table \ > __attribute__ ((unused, alias("mbp_device_table"))); > > So 'struct dmi_device_id' isn't ever really used -- it's just like a > forward declaration of a struct, and the compiler doesn't care because > it never needs to know anything more about that struct. > > Not ideal though -- we should probably see if we can fix it. I suspect > it's not worth a global change of dmi_system_id to dmi_device_id > though... got any better ideas? > > Maybe we could change MODULE_GENERIC_TABLE to be more agnostic about the > datatype -- just call it and 'extern char'. After all, it's only for the > linker.
Let's do it the most staightforward way :-)
[PATCH] Fixup MODULE_DEVICE_TABLE(dmi, ...)
drivers/video/backlight/mbp_nvidia_bl.c:114: error: storage size of '__mod_dmi_device_table' isn't known
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> ---
include/linux/mod_devicetable.h | 1 + 1 file changed, 1 insertion(+)
--- a/include/linux/mod_devicetable.h +++ b/include/linux/mod_devicetable.h @@ -443,6 +443,7 @@ struct dmi_system_id { struct dmi_strmatch matches[4]; void *driver_data; }; +#define dmi_device_id dmi_system_id /* fixup MODULE_DEVICE_TABLE(dmi,...); */ #endif #define DMI_MATCH(a, b) { a, b }
| |