lkml.org 
[lkml]   [2008]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateThu, 20 Nov 2008 09:13:07 +0100
FromIngo Molnar <>
SubjectRe: [PATCH 0/9] powerpc: port of dynamic ftrace

* Steven Rostedt <rostedt@goodmis.org> wrote:

> ----
> arch/powerpc/Kconfig | 2 +
> arch/powerpc/include/asm/ftrace.h | 14 +-
> arch/powerpc/include/asm/module.h | 16 ++-
> arch/powerpc/kernel/ftrace.c | 473 +++++++++++++++++++++++++++++++++---
> arch/powerpc/kernel/idle.c | 5 +
> arch/powerpc/kernel/module_32.c | 10 +
> arch/powerpc/kernel/module_64.c | 13 +
> arch/x86/include/asm/ftrace.h | 9 +-
> arch/x86/kernel/ftrace.c | 168 +++++++++++++-
> include/linux/ftrace.h | 51 ++++-
> kernel/module.c | 2 +-
> kernel/trace/ftrace.c | 137 ++++++------
> scripts/recordmcount.pl | 20 ++-
> 13 files changed, 790 insertions(+), 130 deletions(-)

Hm, something like this shouldnt be pulled into the powerpc tree: it
touches the core kernel, x86 code and ftrace code as well.

Please do the suggestion i outlined and which Paul agreed with:
prepare a branch that touches _only_ powerpc files and gets these
changes there, without actually breaking the build on powerpc. And
please do not name the branch as "hack" - we dont want Paul to pull
such a branch name - it will show up in the upstream git logs.

Those changes should only touch powerpc files. Do not try to shoe-horn
already applied ftrace commits into a separate branch with different
sha1's. Yes, ftrace wont be enable-able on powerpc when that is
pulled, but it will only be for a brief period shortly before the
merge window. (and it will all just work fine when integrated
together)

Once this branch is done, and once Paul agrees that it looks OK-ish to
him, we can put it into ftrace-next straight away [but still keep it
in a separate topic tree in tip/tracing/powerpc - so it can all be
reconsidered reversibly if it causes too much merge trouble]. Paul
will then be able to pull it in a few weeks, in the runup to the
v2.6.29 merge window.

The other option is to go the slow route of 2-3 kernel releases to
pull this all off.

ok?

Ingo


\
 
 \ /
  Last update: 2008-11-20 09:15    [from the cache]
©2003-2010