Messages in this thread | | | Date | Thu, 20 Nov 2008 08:35:01 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] [GENDISK] fix disk_part_tbl always alloced in node 0: set node_id before refered in alloc_disk |
| |
On Thu, Nov 20 2008, crquan@gmail.com wrote: > From: Cheng Renquan <crquan@gmail.com> > > disk->node_id will be refered in allocating in disk_expand_part_tbl, so we > should set it before disk->node_id is refered. > > Signed-off-by: Cheng Renquan <crquan@gmail.com> > --- > block/genhd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block/genhd.c b/block/genhd.c > index 27549e4..2f7feda 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -1102,6 +1102,7 @@ struct gendisk *alloc_disk_node(int minors, int node_id) > kfree(disk); > return NULL; > } > + disk->node_id = node_id; > if (disk_expand_part_tbl(disk, 0)) { > free_part_stats(&disk->part0); > kfree(disk); > @@ -1116,7 +1117,6 @@ struct gendisk *alloc_disk_node(int minors, int node_id) > device_initialize(disk_to_dev(disk)); > INIT_WORK(&disk->async_notify, > media_change_notify_thread); > - disk->node_id = node_id; > } > return disk; > }
Good spotting, applied!
-- Jens Axboe
| |