Messages in this thread | | | Date | Thu, 20 Nov 2008 07:20:46 +0100 | From | "Antonio R. Costa" <> | Subject | Fwd: [PATCH] mmc: atmel-mci: move atmel-mci.h file to include/linux |
| |
Hi all, I agree with Pierre.
I find pretty confusing to mix protocol .h file with drver specific includes. Why can't we have something like:
include/linux/mmc include/drivers/mmc
Ciao, Antnoio
2008/11/19 Pierre Ossman <drzeus@drzeus.cx> > > On Thu, 13 Nov 2008 15:43:34 +0100 > Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > > > Ben Dooks : > > > > > > Would people object to putting this in include/linux/mmc/atmel.h > > > to avoid making include/linux abound with device/subsystem/machine > > > specific header files? > > > > I tend to agree *but* it seems that header files in include/linux/mmc > > are mostly sd/mmc subsystem core files (I mean, not driver ones). > > Although, a bunch of atmel-a_driver.h files are already in include/linux... > > > > Pierre, a comment ? > > > > I'd prefer if include/linux/mmc could stay clean and just have core > stuff since the header files are basically the reference documentation > for the subsystem. But if you can't find any other way... > > -- > -- Pierre Ossman > > WARNING: This correspondence is being monitored by the > Swedish government. Make sure your server uses encryption > for SMTP traffic and consider using PGP for end-to-end > encryption.
| |