Messages in this thread | | | Date | Thu, 20 Nov 2008 13:16:34 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 2.6.28-rc5 05/11] kmemleak: Add support for i386 |
| |
* Catalin Marinas <catalin.marinas@arm.com> wrote:
> This patch adds the kmemleak-related entries to the vmlinux.lds.S > linker script. > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> > --- > arch/x86/kernel/vmlinux_32.lds.S | 1 +
a small detail: a better changelog would be:
| x86: provide _sdata | | Impact: provide generic symbol | | _sdata is a common symbol defined by many architectures and made | available to the core kernel via asm-generic/sections.h. | | Add it to x86 too, so that kmemleak can make use of it.
it is more informative this way, and would be in the customary x86 commit style.
Ingo
| |