Messages in this thread Patch in this message | | | From | Matt Fleming <> | Subject | [PATCH 1/3] HPET: Convert WARN_ON to WARN_ON_ONCE | Date | Sun, 2 Nov 2008 16:04:18 +0000 |
| |
It is possible to flood the console with call traces if the WARN_ON condition is true because of the frequency with which this function is called.
Signed-off-by: Matt Fleming <mjf@gentoo.org> --- arch/x86/kernel/hpet.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 77017e8..f10f946 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -322,7 +322,7 @@ static int hpet_next_event(unsigned long delta, * what we wrote hit the chip before we compare it to the * counter. */ - WARN_ON((u32)hpet_readl(HPET_T0_CMP) != cnt); + WARN_ON_ONCE((u32)hpet_readl(HPET_T0_CMP) != cnt); return (s32)((u32)hpet_readl(HPET_COUNTER) - cnt) >= 0 ? -ETIME : 0; } -- 1.5.6.4
| |