Messages in this thread |  | | | Date | Wed, 19 Nov 2008 08:53:19 +0100 | | From | Ingo Molnar <> | | Subject | Re: [patch] sched: add locking when update the task_group's cfs_rq[] array. | |
* Ken Chen <kenchen@google.com> wrote:
> @@ -1513,8 +1513,12 @@ static int tg_shares_up
> unsigned long weight, rq_weight = 0;
> unsigned long shares = 0;
> struct sched_domain *sd = data;
> + unsigned long flags;
> int i;
>
> + if (!spin_trylock_irqsave(&tg->tg_lock, flags))
> + return 0;
hm, why trylock?
Ingo
|  |