Messages in this thread | | | Date | Wed, 19 Nov 2008 13:58:40 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] n-trig digitizer quirks |
| |
On Tue, 18 Nov 2008, Rafi Rubin wrote:
> +static int ntrig_input_mapping(struct hid_device *hdev, struct hid_input *hi, > + struct hid_field *field, struct hid_usage *usage, > + unsigned long **bit, int *max) > +{ > + if ( (usage->hid & HID_USAGE_PAGE) == HID_UP_DIGITIZER && > + (usage->hid & 0xff) == 0x47) { > + nt_map_key_clear(BTN_TOOL_DOUBLETAP); > + return 1; > + } > + return 0; > +}
Could you please keep standard linux-kernel indenting style? I.e. something like
static int ntrig_input_mapping(struct hid_device *hdev, struct hid_input *hi, struct hid_field *field, struct hid_usage *usage, unsigned long **bit, int *max) { if ((usage->hid & HID_USAGE_PAGE) == HID_UP_DIGITIZER && (usage->hid & 0xff) == 0x47) { nt_map_key_clear(BTN_TOOL_DOUBLETAP); return 1; } return 0; }
> + > +static int ntrig_input_mapped(struct hid_device *hdev, struct hid_input *hi, > + struct hid_field *field, struct hid_usage *usage, > + unsigned long **bit, int *max) > +{ > + unsigned long quirks = (unsigned long)hid_get_drvdata(hdev);
This could be removed, as it is never used, right?
> +HID_COMPAT_LOAD_DRIVER(ntrig);
Also please don't forget to add HID_COMPAT_CALL_DRIVER() entry into hid-dummy.c
Besides that it looks OK, so please resend with the above issues fixed, and I'll queue it in my tree.
Thanks,
-- Jiri Kosina SUSE Labs
| |