lkml.org 
[lkml]   [2008]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kernel/ksysfs.c:fix dependence on CONFIG_NET
    On Sun, 16 Nov 2008 18:22:09 +0800
    tom.leiming@gmail.com wrote:

    > From: Ming Lei <tom.leiming@gmail.com>
    >
    > Access to uevent_seqnum and uevent_helper does not need to
    > depend on CONFIG_NET, so remove it.
    >
    > Signed-off-by: Ming Lei <tom.leiming@gmail.com>
    > ---
    > kernel/ksysfs.c | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c
    > index 08dd8ed..528dd78 100644
    > --- a/kernel/ksysfs.c
    > +++ b/kernel/ksysfs.c
    > @@ -24,7 +24,7 @@ static struct kobj_attribute _name##_attr = __ATTR_RO(_name)
    > static struct kobj_attribute _name##_attr = \
    > __ATTR(_name, 0644, _name##_show, _name##_store)
    >
    > -#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
    > +#if defined(CONFIG_HOTPLUG)
    > /* current uevent sequence number */
    > static ssize_t uevent_seqnum_show(struct kobject *kobj,
    > struct kobj_attribute *attr, char *buf)
    > @@ -137,7 +137,7 @@ struct kobject *kernel_kobj;
    > EXPORT_SYMBOL_GPL(kernel_kobj);
    >
    > static struct attribute * kernel_attrs[] = {
    > -#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
    > +#if defined(CONFIG_HOTPLUG)
    > &uevent_seqnum_attr.attr,
    > &uevent_helper_attr.attr,
    > #endif

    I think the story here is that uevent uses netlink, and with
    CONFIG_NET=n, we have no netlink, so that code couldn't do anything
    anyway.



    \
     
     \ /
      Last update: 2008-11-19 00:41    [W:0.030 / U:0.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site