lkml.org 
[lkml]   [2008]   [Nov]   [18]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 18 Nov 2008 08:48:52 +0100
FromIngo Molnar <>
SubjectRe: [PATCH] kernel/profile.c: Fix section mismatch warning.
* Rakib Mullick <rakib.mullick@gmail.com> wrote:

> Impact: Fix section mismatch warning in kernel/profile.c
> 
> Here, profile_nop function has been called from a non-init function
> create_hash_tables(void). Which generetes a section mismatch warning.
> Previously, create_hash_tables(void) was a init function. So, removing
> __init from create_hash_tables(void) requires profile_nop to be
> non-init. This patch makes profile_nop function inline and fixes the
> following warning:
> 
> WARNING: vmlinux.o(.text+0x6ebb6): Section mismatch in reference from
> the function create_hash_tables() to the function
> .init.text:profile_nop()
> The function create_hash_tables() references
> the function __init profile_nop().
> This is often because create_hash_tables lacks a __init
> annotation or the annotation of profile_nop is wrong.
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> 
> --- linux-2.6-orig/kernel/profile.c	2008-11-17 20:30:42.000000000 +0600
> +++ linux-2.6/kernel/profile.c	2008-11-18 09:39:58.000000000 +0600
> @@ -544,7 +544,7 @@ static const struct file_operations proc
>  };
> 
>  #ifdef CONFIG_SMP
> -static void __init profile_nop(void *unused)
> +static inline void profile_nop(void *unused)
>  {
>  }

applied to tip/core/urgent, thanks!

	Ingo


\
 
 \ /
  Last update: 2008-11-18 08:51    [from the cache]
©2003-2008