lkml.org 
[lkml]   [2008]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 28/46] m68k: Fix off-by-one in m68k_setup_user_interrupt()
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Geert Uytterhoeven <geert@linux-m68k.org>

    commit 27123cbc264de89ce6951b1b4c84c223eb0f1702 upstream.

    commit 69961c375288bdab7604e0bb1c8d22999bb8a347 ("[PATCH] m68k/Atari:
    Interrupt updates") added a BUG_ON() with an incorrect upper bound
    comparison, which causes an early crash on VME boards, where IRQ_USER is
    8, cnt is 192 and NR_IRQS is 200.

    Reported-by: Stephen N Chivers <schivers@csc.com.au>
    Tested-by: Kars de Jong <jongk@linux-m68k.org>
    Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/m68k/kernel/ints.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/m68k/kernel/ints.c
    +++ b/arch/m68k/kernel/ints.c
    @@ -133,7 +133,7 @@ void __init m68k_setup_user_interrupt(un
    {
    int i;

    - BUG_ON(IRQ_USER + cnt >= NR_IRQS);
    + BUG_ON(IRQ_USER + cnt > NR_IRQS);
    m68k_first_user_vec = vec;
    for (i = 0; i < cnt; i++)
    irq_controller[IRQ_USER + i] = &user_irq_controller;
    --


    \
     
     \ /
      Last update: 2008-11-17 08:33    [W:0.024 / U:0.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site