lkml.org 
[lkml]   [2008]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH v2] x86: more general identifier for Phoenix BIOS
Phoenix BIOSes variously identify their vendor as "Phoenix Technologies, 
LTD" or "Phoenix Technologies LTD" (without the comma.)

This patch makes the identification string in the bad_bios_dmi_table
more general (following a suggestion by Ingo Molnar), so that both
versions are handled.

Again, the patched file compiles cleanly and the patch has been tested
successfully on my machine.

Signed-off-by: Philipp Kohlbecher <xt28@gmx.de>

---
arch/x86/kernel/setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 0fa6790..9d5674f 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -764,7 +764,7 @@ static struct dmi_system_id __initdata
bad_bios_dmi_table[] = {
.callback = dmi_low_memory_corruption,
.ident = "Phoenix BIOS",
.matches = {
- DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies, LTD"),
+ DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies"),
},
},
#endif
Ingo Molnar wrote:
> * H. Peter Anvin <hpa@zytor.com> wrote:
>
>> Philipp Kohlbecher wrote:
>>> My laptop (a Samsung X20) contains a Phoenix BIOS and would
>>> benefit from patch 1e22436eba84edfec9c25e5a25d09062c4f91ca9 (x86:
>>> reserve low 64K on AMI and Phoenix BIOS boxen).
>>>
>>> However, according to /sys/class/dmi/id/bios_vendor, the BIOS
>>> identifies its vendor as "Phoenix Technologies LTD" (sans the
>>> comma).
>
> Note that we should do a simpler patch: just change the string to
> "Phoenix Technologies" and that will provide a proper match. (DMI
> matches work on substrings too)
>

Done. (I wasn't sure whether you were saying that *I* should write this
simpler patch or that you would. Anyway, here it is.)


\
 
 \ /
  Last update: 2008-11-16 12:13    [from the cache]
©2003-2011 Jasper Spaans