Messages in this thread | | | Date | Sun, 16 Nov 2008 00:16:37 -0800 (PST) | Subject | Re: [PATCH 3/7] memcontrol: use simple_malloc()/simple_free() | From | David Miller <> |
| |
From: Alexey Dobriyan <adobriyan@gmail.com> Date: Sun, 16 Nov 2008 07:51:28 +0300
> On Sun, Nov 16, 2008 at 12:33:46PM +0800, Lai Jiangshan wrote: > > use simple_malloc()/simple_free() instead of current codes. > > struct mem_cgroup can't reach the size when kmalloc starts failing.
That's not the point.
When you got past a page, kmalloc/gfp allocations are less reliable, and people also want NUMA spreading when possible.
That's why we use PAGE_SIZE as the table vmalloc() breakpoint. We do this in many places already, with the exact same heuristics, and for the exact same reasons.
| |