lkml.org 
[lkml]   [2008]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][for 2.6.28] Remove -mno-spe flags as they dont belong
    Kumar Gala wrote:
    > For some unknown reason at Steven Rostedt added in disabling of the SPE
    > instruction generation for e500 based PPC cores in commit
    > 6ec562328fda585be2d7f472cfac99d3b44d362a.
    >

    The unknown reason was that my PPC64 failed to compile without it ;-) It
    was unknown because I forgot to mention that in the change log (my bad).

    On Monday, I'll apply this patch and make sure that my PPC64 still compiles.

    -- Steve

    > We are removing it because:
    >
    > 1. It generates e500 kernels that don't work
    > 2. its not the correct set of flags to do this
    > 3. we handle this in the arch/powerpc/Makefile already
    > 4. its unknown in talking to Steven why he did this
    >
    > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
    > ---
    > kernel/Makefile | 4 +---
    > 1 files changed, 1 insertions(+), 3 deletions(-)
    >
    > diff --git a/kernel/Makefile b/kernel/Makefile
    > index 9a3ec66..19fad00 100644
    > --- a/kernel/Makefile
    > +++ b/kernel/Makefile
    > @@ -11,8 +11,6 @@ obj-y = sched.o fork.o exec_domain.o panic.o printk.o \
    > hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o \
    > notifier.o ksysfs.o pm_qos_params.o sched_clock.o
    >
    > -CFLAGS_REMOVE_sched.o = -mno-spe
    > -
    > ifdef CONFIG_FUNCTION_TRACER
    > # Do not trace debug files and internal ftrace files
    > CFLAGS_REMOVE_lockdep.o = -pg
    > @@ -21,7 +19,7 @@ CFLAGS_REMOVE_mutex-debug.o = -pg
    > CFLAGS_REMOVE_rtmutex-debug.o = -pg
    > CFLAGS_REMOVE_cgroup-debug.o = -pg
    > CFLAGS_REMOVE_sched_clock.o = -pg
    > -CFLAGS_REMOVE_sched.o = -mno-spe -pg
    > +CFLAGS_REMOVE_sched.o = -pg
    > endif
    >
    > obj-$(CONFIG_FREEZER) += freezer.o
    >



    \
     
     \ /
      Last update: 2008-11-15 19:13    [W:0.028 / U:29.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site