Messages in this thread |  | | | Date | Fri, 14 Nov 2008 17:06:37 +0900 | | From | KAMEZAWA Hiroyuki <> | | Subject | Re: [PATCH] memcg: reduce size of per-cpu-stat to be appropriate size. | |
On Fri, 14 Nov 2008 13:33:49 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> Li Zefan wrote:> >>>> +static int mem_cgroup_size(void)> >>> inline this function?> >>>> >> necessary ? > >>> > > > Not so necessary IMO. It's called when a cgroup is created and removed, that
> > is mkdir and rmdir, where performance is not critical.
> > > > I think most new compilers can automatically inline such functions, but a hint
> for the older ones is always a good practice.>
Adding "inline" is easy. But, IMHO, adding "inline" to not-performance-critical part
is just confusing people.
I want to see "inline" where inline is obviously good/necessary for performance.
Thanks,
-Kame
|  |