lkml.org 
[lkml]   [2008]   [Nov]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 14 Nov 2008 09:55:53 +0200
FromArtem Bityutskiy <>
SubjectRe: [PATCH] filesystems: use has_capability_noaudit interface for reserved blocks checks
Eric Paris wrote:
> ext[2,3,4], ufs, and ubifs all check for  CAP_SYS_RESOURCE to determine
> if they should allow reserved blocks to be used.  A process not having
> this capability is not failing some security decision and should not be
> audited.  Thus move to using has_capability_noaudit.
> 
> Signed-off-by: Eric Paris <eparis@redhat.com>
> ---

UBIFS part looks OK, as long as the whole idea of the patch is right, which
I have not checked, but assume it is.

The only question is are you sure exporting 'cap_capable()' is relevant
to this patch? You do not seem to call it directly.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-11-14 09:03    [from the cache]
©2003-2008