lkml.org 
[lkml]   [2008]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [patch 7/7] SDHCI: Add change_clock callback for glue drivers
    On Mon, 03 Nov 2008 20:09:51 +0000
    Ben Dooks <ben-linux@fluff.org> wrote:

    > Add a change_clock callback to allow drivers to update
    > device specific clock selections and control registers
    > when there is a change in clock.
    >
    > Move the main part of sdhci_set_clock() to a new routine
    > which can be called by the glue drivers to do the sdhci
    > standard clock management.
    >
    > Update the sdhci-s3c driver to use this to select the
    > appropriate clock source when clocks change.
    >
    > Signed-off-by: Ben Dooks <ben-linux@fluff.org>
    >

    I'm afraid I don't quite follow on the requirements here. Care to
    elaborate as to why this is needed?

    > Index: linux.git/drivers/mmc/host/sdhci-pci.c
    > ===================================================================
    > --- linux.git.orig/drivers/mmc/host/sdhci-pci.c 2008-11-03 12:17:50.000000000 +0000
    > +++ linux.git/drivers/mmc/host/sdhci-pci.c 2008-11-03 12:18:41.000000000 +0000
    > @@ -391,6 +391,7 @@ static int sdhci_pci_enable_dma(struct s
    >
    > static struct sdhci_ops sdhci_pci_ops = {
    > .enable_dma = sdhci_pci_enable_dma,
    > + .change_clock = sdhci_change_clock,
    > };
    >
    > /*****************************************************************************\

    This seems pointless :)

    > @@ -950,6 +955,8 @@ out:
    > host->clock = clock;
    > }
    >
    > +EXPORT_SYMBOL_GPL(sdhci_set_clock);
    > +

    Wrong symbol. :)

    --
    -- Pierre Ossman

    Linux kernel, MMC maintainer http://www.kernel.org
    rdesktop, core developer http://www.rdesktop.org
    WARNING: This correspondence is being monitored by the
    Swedish government. Make sure your server uses encryption
    for SMTP traffic and consider using PGP for end-to-end
    encryption.


    \
     
     \ /
      Last update: 2008-11-14 23:23    [W:0.022 / U:1.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site