lkml.org 
[lkml]   [2008]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 5/7] SDHCI: Samsung SDHCI (HSMMC) driver
    On Mon, 03 Nov 2008 20:09:49 +0000
    Ben Dooks <ben-linux@fluff.org> wrote:

    > +static void sdhci_s3c_sel_sclk(struct sdhci_host *host)
    > +{
    > + struct sdhci_s3c *ourhost = to_s3c(host);
    > +
    > + /* select sclk */
    > + u32 tmp = readl(host->ioaddr + 0x80);
    > +
    > + if ((tmp & (3 << 4)) == (2 << 4))
    > + return;
    > +
    > + tmp &= ~(3<<4);
    > + tmp |= (2 << 4);
    > + writel(tmp, host->ioaddr + 0x80);
    > +}

    No defines for this? This is not terribly readable.

    > + if (pdata->cfg_card)
    > + pdata->cfg_card(ourhost->pdev, host->ioaddr,
    > + ios, host->mmc->card);

    What's the deal here? Hosts shouldn't know more about the card than the
    MMC core tells them.

    Since I have no hardware for this, could you take it upon you to handle
    support for these chips? I'd like a MAINTAINERS patch for that as well.

    Rgds
    --
    -- Pierre Ossman

    Linux kernel, MMC maintainer http://www.kernel.org
    rdesktop, core developer http://www.rdesktop.org

    WARNING: This correspondence is being monitored by the
    Swedish government. Make sure your server uses encryption
    for SMTP traffic and consider using PGP for end-to-end
    encryption.


    \
     
     \ /
      Last update: 2008-11-14 22:51    [W:0.020 / U:1.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site