lkml.org 
[lkml]   [2008]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Fix an uninitialised variable warning in the 8250 driver
Date
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> Current versions of gcc that I've tested get this all correct just fine
> for x86 at least.

gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)

> Do check that the BUG_ON() helper for whatever platform you are using
> needs to correctly indicate that its BUG spewing path may not return
> (__attibute((__noreturn__)). I seem to remember some of the architectures
> are broken on that.

x86_64 - which doesn't do that. It uses asm volatile and an infinite for-loop.

Surely having BUG() retreat through a noreturn function may lose important
state, such as the function that issued the bug as the compiler is under no
requirement to save the return value, and the file/line info may not be
available.

David


\
 
 \ /
  Last update: 2008-11-14 17:53    [W:0.029 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site