Messages in this thread | | | Date | Fri, 14 Nov 2008 16:34:28 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] Fix an uninitialised variable warning in the 8250 driver |
| |
On Fri, 14 Nov 2008 16:20:38 +0000 David Howells <dhowells@redhat.com> wrote:
> Fix an uninitialised variable warning in the 8250 driver: > > CC drivers/serial/8250.o > drivers/serial/8250.c: In function 'serial8250_shutdown': > drivers/serial/8250.c:1612: warning: 'i' may be used uninitialized in this function
Current versions of gcc that I've tested get this all correct just fine for x86 at least.
Do check that the BUG_ON() helper for whatever platform you are using needs to correctly indicate that its BUG spewing path may not return (__attibute((__noreturn__)). I seem to remember some of the architectures are broken on that.
Alan
| |