Messages in this thread | | | Date | Thu, 13 Nov 2008 23:28:23 +0900 (JST) | Subject | Re: [PATCH] mtd: unify mtd partition/device registration | From | Atsushi Nemoto <> |
| |
On Thu, 13 Nov 2008 22:43:50 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote: > On Wed, 12 Nov 2008 18:38:53 -0500, Mike Frysinger <vapier@gentoo.org> wrote: > > Rather than having every map/mtd driver doing the same sequence of > > registering partitions and/or devices, implement common parse_mtd(). > > > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > > --- > > drivers/mtd/mtdcore.c | 37 +++++++++++++++++++++++++++++++++++++ > > include/linux/mtd/mtd.h | 3 +++ > > 2 files changed, 40 insertions(+), 0 deletions(-) > > I like this idea.
Some drivers call both add_mtd_device() and add_mtd_partitions(). The mtd_device is used to access whole flash area (like /dev/hda). How do you think of these usage patterns?
maps/edb7312.c maps/mbx860.c maps/plat-ram.c nand/cafe_nand.c nand/diskonchip.c nand/ndfc.c
Automatic fallback to mtd_device in parse_mtd() is convenient but somewhat unflexible...
--- Atsushi Nemoto
| |