Messages in this thread | | | Date | Thu, 13 Nov 2008 20:58:07 +0900 | From | Hidetoshi Seto <> | Subject | Re: [PATCH] accelerate newidle balancing in relax_domain |
| |
Ingo Molnar wrote: > I agree with making it more sensitive to momentary load fluctuations. > (as long as other metrics do not degrade). > > But this solutin basically overrides the newidle_idx tuning in > topology.h. > > Is there a strong reason to do this tuning dynamically, or could we > just decrease newidle_idx in the appropriate templates in the > topology.h files?
IMHO topology.h should have proper values that will fit 'standard' system usage. I'm not sure that the current values (such as 2 in SD_NODE) is best number or not... And I think it can differ by archs.
If there are no features that will be affected by the changing default newidle_idx values, then we can fix it in the templates. It would be a strong reason - I don't like regression :-)
Thanks, H.Seto
| |