Messages in this thread Patch in this message |  | | | Date | Tue, 11 Nov 2008 16:24:41 -0800 | | From | Greg KH <> | | Subject | [patch 49/49] HID: fix incorrent length condition in hidraw_write() |
| |
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------ From: Jiri Kosina <jkosina@suse.cz>
upstream commit 2b107d629dc0c35de606bb7b010b829cd247a93a
From: Jiri Kosina <jkosina@suse.cz>
The bound check on the buffer length
if (count > HID_MIN_BUFFER_SIZE) is of course incorrent, the proper check is
if (count > HID_MAX_BUFFER_SIZE) Fix it.
Reported-by: Jerry Ryle <jerry@mindtribe.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Cc: Paul Stoffregen <paul@pjrc.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/hid/hidraw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -113,7 +113,7 @@ static ssize_t hidraw_write(struct file if (!dev->hid_output_raw_report) return -ENODEV; - if (count > HID_MIN_BUFFER_SIZE) { + if (count > HID_MAX_BUFFER_SIZE) { printk(KERN_WARNING "hidraw: pid %d passed too large report\n", task_pid_nr(current)); return -EINVAL; --
|  |