Messages in this thread | | | Date | Mon, 10 Nov 2008 16:49:28 -0800 | From | "Darrick J. Wong" <> | Subject | Re: [PATCH 3/5] adt7470: Check input range when sysfs files are written |
| |
On Mon, Nov 10, 2008 at 04:22:14PM -0800, Andrew Morton wrote:
> When writing changelogs, please explain _why_ a change was made, as > well as what the change does.
Sorry about that. Here's a revision:
Implement correct range checking for adt7470 to prevent userland from writing impossible values into the chip, and cap out-of-range values per standard hwmon conventions.
Implement correct rounding of input values per standard hwmon conventions.
Is that better?
(Same goes for the adt7473 patch.)
> Looking at it, I guess it does change the userspace interface in minor > ways, so we should merge it into 2.6.28. Ditto > adt7473-check-inputs-from-sysfs-writes.patch. Agree?
Yes.
--D
| |