lkml.org 
[lkml]   [2008]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v9][PATCH 05/13] Dump memory address space


Serge E. Hallyn wrote:
> Quoting Oren Laadan (orenl@cs.columbia.edu):
>> +/**
>> + * cr_fill_fname - return pathname of a given file
>> + * @path: path name
>> + * @root: relative root
>> + * @buf: buffer for pathname
>> + * @n: buffer length (in) and pathname length (out)
>> + */
>> +static char *
>> +cr_fill_fname(struct path *path, struct path *root, char *buf, int *n)
>> +{
>> + struct path tmp = *root;
>> + char *fname;
>> +
>> + BUG_ON(!buf);
>> + fname = __d_path(path, &tmp, buf, *n);
>> + if (!IS_ERR(fname))
>> + *n = (buf + (*n) - fname);
>> + /*
>> + * FIXME: if __d_path() changed these, it must have stepped out of
>> + * init's namespace. Since currently we require a unified namespace
>> + * within the container: simply fail.
>> + */
>> + if (tmp.mnt != root->mnt || tmp.dentry != root->dentry)
>> + fname = ERR_PTR(-EBADF);
>> +
>> + return fname;
>> +}
>
> You still are not taking the dcache_lock around __d_path.
>

You still are right.

Oren.


\
 
 \ /
  Last update: 2008-11-10 21:39    [W:0.050 / U:0.060 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site