Messages in this thread | | | Date | Sat, 1 Nov 2008 09:49:24 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [RFC][PATCH] saner FASYNC handling on file close |
| |
On Fri, 31 Oct 2008, Al Viro wrote: > > As it is, all instances of ->release() for files that have > ->fasync() need to remember to evict file from fasync lists; forgetting > that creates a hole and we actually have a bunch that *does* forget. > > So let's keep our lives simple - let __fput() check FASYNC in > file->f_flags and call ->fasync() there if it's been set. And lose > that crap in ->release() instances - leaving it there is still valid, > but we don't have to bother anymore. > > Comments?
This looks like "obviously the right thing". Done.
Linus
| |