lkml.org 
[lkml]   [2008]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] saner FASYNC handling on file close


On Fri, 31 Oct 2008, Al Viro wrote:
>
> As it is, all instances of ->release() for files that have
> ->fasync() need to remember to evict file from fasync lists; forgetting
> that creates a hole and we actually have a bunch that *does* forget.
>
> So let's keep our lives simple - let __fput() check FASYNC in
> file->f_flags and call ->fasync() there if it's been set. And lose
> that crap in ->release() instances - leaving it there is still valid,
> but we don't have to bother anymore.
>
> Comments?

This looks like "obviously the right thing". Done.

Linus


\
 
 \ /
  Last update: 2008-11-01 17:53    [W:0.034 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site