Messages in this thread | | | Date | Sat, 1 Nov 2008 19:32:58 +0000 | From | Al Viro <> | Subject | Re: [PATCH] el3_common_init() should be __devinit, not __init |
| |
On Sat, Nov 01, 2008 at 10:27:57PM +0300, Alexey Dobriyan wrote: > On Sat, Nov 01, 2008 at 07:16:14PM +0000, Al Viro wrote: > > On Sat, Nov 01, 2008 at 10:12:50PM +0300, Alexey Dobriyan wrote: > > > On Sat, Nov 01, 2008 at 06:20:19PM +0000, Al Viro wrote: > > > > -static int __init el3_common_init(struct net_device *dev) > > > > +static int __devinit el3_common_init(struct net_device *dev) > > > > > > Al, here is much better patch: > > > > [essentially kill devinit/cpuinit] > > > > What the hell makes it better? > > Wasting efforts for too little gain? > > More or less every distro enables HOTPLUG and HOTPLUG_CPU.
More or less every distro shits udev and hald; it's not a reason to make the corrsponding stuff in the kernel mandatory. The same applies here...
| |