Messages in this thread Patch in this message |  | | | From | Theodore Ts'o <> | | Subject | [PATCH 41/42] ext4: Avoid double dirtying of super block in ext4_put_super() | | Date | Thu, 9 Oct 2008 00:05:59 -0400 |
| |
From: Andi Kleen <andi@firstfloor.org>
While reading code I noticed that ext4_put_super() dirties the superblock bh twice. It is always done in ext4_commit_super() too. Remove the redundant dirty operation. Should be a nop semantically.
Signed-off-by: Andi Kleen <ak@linux.intel.com> --- fs/ext4/super.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9c02146..7d86560 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -512,8 +512,6 @@ static void ext4_put_super(struct super_block *sb) if (!(sb->s_flags & MS_RDONLY)) { EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER); es->s_state = cpu_to_le16(sbi->s_mount_state); - BUFFER_TRACE(sbi->s_sbh, "marking dirty"); - mark_buffer_dirty(sbi->s_sbh); ext4_commit_super(sb, es, 1); } if (sbi->s_proc) { -- 1.5.6.1.205.ge2c7.dirty
|  |