Messages in this thread | | | Date | Tue, 7 Oct 2008 14:19:12 -0700 | From | Mark Fasheh <> | Subject | Re: [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees |
| |
On Wed, Oct 01, 2008 at 11:12:05PM -0700, Andrew Morton wrote: > > On Wed, 24 Sep 2008 15:00:52 -0700 Mark Fasheh <mfasheh@suse.com> wrote: > > + if (eb_bh) > > + brelse(eb_bh); > > brelse(0) is legal. Please do an fs-wide review for this.
Ok, I'll queue that up. I'll watch to make sure that new patches from here on won't do this.
> It shouldn't affect code generation because brelse() is inlined.
Fair enough, thanks. --Mark
-- Mark Fasheh
| |