lkml.org 
[lkml]   [2008]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] drivers/s390/cio/chsc_sch.c: Correct use of ! and &
On Sat, Oct 04, 2008 at 10:05:47PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that
> involved converting !x & y to !(x & y). The code below shows the same
> pattern, and thus should perhaps be fixed in the same way. In particular,
> the result of !scsw_stctl(&request->irb.scsw) & SCSW_STCTL_STATUS_PEND is
> always just !scsw_stctl(&request->irb.scsw).
> [...]
> - if (!scsw_stctl(&request->irb.scsw) & SCSW_STCTL_STATUS_PEND)
> + if (!(scsw_stctl(&request->irb.scsw) & SCSW_STCTL_STATUS_PEND))
> return -EIO;
> backed_up = scsw_cstat(&request->irb.scsw) & SCHN_STAT_CHAIN_CHECK;
> request->irb.scsw.cmd.cstat &= ~SCHN_STAT_CHAIN_CHECK;

Nice finding. Thank you!


\
 
 \ /
  Last update: 2008-10-06 12:55    [W:0.093 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site