Messages in this thread | | | Subject | Re: [PATCH -mm -v3] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h | From | Huang Ying <> | Date | Tue, 07 Oct 2008 09:09:59 +0800 |
| |
Hi, Geert,
On Mon, 2008-10-06 at 10:48 +0200, Geert Uytterhoeven wrote: > On Mon, 6 Oct 2008, Huang Ying wrote: > > From: Huang Ying <ying.huang@intel.com> > > > > asm/atomic.h contains both declaration and implementation of atomic_t. So > > there are some implementation related files included in asm/atomic.h. And > > atomic_t is a typedef. Combination of above makes it impossible to use > > atomic_t in files included by atomic.h. Such as atomic_t can not be used > > in linux/kernel.h on i386, because it is included by asm/atomic.h. > > > > It is reasonable to separate declaration from implementation. So a new > > file atomic_def.h is added for every architecture to accommodate the > > declaration of atomic_t. > > And how many of these atomic_def.h are identical? > asm-generic?
Most of them are identical. But <asm/atomic_def.h> will be a public API, included by not only <asm/atomic.h> but also <linux/xxx.h>. I don't know how to put it in asm-generic.
Best Regards, Huang Ying [unhandled content-type:application/pgp-signature] | |