lkml.org 
[lkml]   [2008]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -mm -v3] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h
From
Date
Hi, Geert,

On Mon, 2008-10-06 at 10:48 +0200, Geert Uytterhoeven wrote:
> On Mon, 6 Oct 2008, Huang Ying wrote:
> > From: Huang Ying <ying.huang@intel.com>
> >
> > asm/atomic.h contains both declaration and implementation of atomic_t. So
> > there are some implementation related files included in asm/atomic.h. And
> > atomic_t is a typedef. Combination of above makes it impossible to use
> > atomic_t in files included by atomic.h. Such as atomic_t can not be used
> > in linux/kernel.h on i386, because it is included by asm/atomic.h.
> >
> > It is reasonable to separate declaration from implementation. So a new
> > file atomic_def.h is added for every architecture to accommodate the
> > declaration of atomic_t.
>
> And how many of these atomic_def.h are identical?
> asm-generic?

Most of them are identical. But <asm/atomic_def.h> will be a public API,
included by not only <asm/atomic.h> but also <linux/xxx.h>. I don't know
how to put it in asm-generic.

Best Regards,
Huang Ying
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-10-07 03:13    [W:0.031 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site