Messages in this thread | | | Date | Mon, 6 Oct 2008 14:13:06 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 0/0] SIGWINCH problem with terminal apps |
| |
> So as a quick solution I made patches which move mentioned updates > before kill_pgrp() calls. As I tested modified kernel there is no > observed effect now. So I send patchs.
NAK - this might happen to make the race miss on your box but it's not a fix of any kind.
> There are some places where kill_pgrp() call is used and some variable > is changed after it. It should be considered if this code is always > working properly or some race scheduler condition exists.
The code was never race free, the scheduler change made the problem show up more. Later 2.6.27-rc has patches that use the termios lock across TIOCG/SWINSZ and deal with the problem properly.
Alan
| |