Messages in this thread |  | | | Date | Fri, 31 Oct 2008 08:30:07 -0700 | | From | Randy Dunlap <> | | Subject | Re: [PATCH] ftrace: update txt document |
| |
Steven Rostedt wrote: > I finally got around to looking at the review notes. > > On Sun, 26 Oct 2008, Randy Dunlap wrote: >>> >>> # sysctl kernel.ftrace_enabled=1 >>> - # echo ftrace > /debug/tracing/current_tracer >>> + # echo function > /debug/tracing/current_tracer >>> # echo 1 > /debug/tracing/tracing_enabled >>> # usleep 1 >>> # echo 0 > /debug/tracing/tracing_enabled >>> # cat /debug/tracing/trace >>> -# tracer: ftrace >>> +# tracer: function >>> # >>> # TASK-PID CPU# TIMESTAMP FUNCTION >>> # | | | | | >> General comment #2: debugfs is normally mounted at /sys/kernel/debug >> (which Doc/x86/pat.txt, Doc/filesystems/relay.txt, >> Doc/infiniband/ipoib.txt, and Doc/usb/usbmon.txt know about). >> Please either use /sys/kernel/debug or use what Doc/kernel-parameters.txt >> uses: <debugfs> (for the mount point). I.e., don't use a poor example >> in the doc text. > > In the beginning of the document I did have a disclaimer:
OK, sorry about that. Somehow I missed seeing it.
> ------------------------ > To mount the debugfs system: > > # mkdir /debug > # mount -t debugfs nodev /debug > > (Note: it is more common to mount at /sys/kernel/debug, but for simplicity > this document will use /debug) > ------------------------ > > I know the recommended place is /sys/kernel/debug, but I never use it. And > I know many others that do not either. It is just easier to make the > /debug directory. I feel this is more of a guideline than something > that must be enforced. But if you do feel strongly on this subject, I > can change it to /sys/kernel/debug (which I absolutely loathe).
-- ~Randy
|  |