Messages in this thread | | | Date | Fri, 31 Oct 2008 15:17:02 +0100 | From | Jens Axboe <> | Subject | Re: [dm-devel] [PATCH] Add gfp_mask to bio_integrity_clone() |
| |
On Fri, Oct 31 2008, Martin K. Petersen wrote: > >>>>> "Jun'ichi" == Jun'ichi Nomura <j-nomura@ce.jp.nec.com> writes: > > Jun'ichi> What do you think about adding gfp_mask parameter to > Jun'ichi> bio_integrity_clone() like the attached patch? > > Jun'ichi> It also seems natural to inherit gfp_mask from bio_clone > Jun'ichi> when bio_integrity_clone is called from it. Since > Jun'ichi> bio_clone() is the only caller of bio_integrity_clone() in > Jun'ichi> 2.6.28-rc2 and all in-tree callers of bio_clone() are using > Jun'ichi> GFP_NOIO, the patch does nothing other than changing the > Jun'ichi> interface. > > Looks good to me. I'll update the non-multipath DM bits accordingly. > > Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Shall I just include this in the 2.6.29 branch?
-- Jens Axboe
| |