lkml.org 
[lkml]   [2008]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Fix hid_device_id for cross compiling
Date
Andrew Morton <akpm@linux-foundation.org> writes:

> On Sun, 26 Oct 2008 00:30:18 +0200 Andreas Schwab <schwab@suse.de> wrote:
>
>> struct hid_device_id contains hidden padding which is bad for cross
>> compiling. Make the padding explicit and consistent across
>> architectures.
>>
>
> What is "bad" about it?

It is bad because it depends on the alignment restrictions of the
architecture. On m68k everything is aligned on a 2-byte boundary, so
this padding does not exist.

> Can you expand a bit on the problem which is being fixed here?

It's the well known cross compiling problem with modpost that has bitten
us so often before. This one is even worse, because modpost would
silently read bogus values since the struct size is the same, only the
padding moves elsewhere.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-10-30 10:23    [W:0.035 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site