lkml.org 
[lkml]   [2008]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] fix smp generic helper voyager breakage
    From
    Date
    On Thu, 2008-10-30 at 22:54 +0100, Ingo Molnar wrote:
    > * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
    >
    > > +++ b/arch/x86/Kconfig
    > > @@ -167,9 +167,11 @@ config GENERIC_PENDING_IRQ
    > > config X86_SMP
    > > bool
    > > depends on SMP && ((X86_32 && !X86_VOYAGER) || X86_64)
    > > - select USE_GENERIC_SMP_HELPERS
    > > default y
    > >
    > > +config USE_GENERIC_SMP_HELPERS
    > > + def_bool y
    > > +
    >
    > uhm, that's a bogus change - USE_GENERIC_SMP_HELPERS must not be set
    > on UP. This will break all UP compilations, on all x86 UP boxes:

    Heh, that would be one thing I don't build in my test rig.

    > kernel/softirq.c: In function '__try_remote_softirq':
    > kernel/softirq.c:522: error: implicit declaration of function '__smp_call_function_single'
    >
    > so i've removed your patch for now.

    OK, I'll update it ... I assume it should depend on CONFIG_SMP then?

    James




    \
     
     \ /
      Last update: 2008-10-30 23:09    [W:0.042 / U:32.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site