[lkml]   [2008]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch 4/7] mm: cpuset aware reclaim writeout
    From: Christoph Lameter <>

    During direct reclaim we traverse down a zonelist and are carefully
    checking each zone if it's a member of the active cpuset. But then we
    call pdflush without enforcing the same restrictions. In a larger system
    this may have the effect of a massive amount of pages being dirtied and
    then either

    - no writeout occurs because global dirty limits have not been reached,

    - writeout starts randomly for some dirty inode in the system. pdflush
    may just write out data for nodes in another cpuset and miss doing
    proper dirty handling for the current cpuset.

    In both cases, dirty pages in the zones of interest may not be affected
    and writeout may not occur as necessary.

    Fix that by restricting pdflush to the active cpuset. Writeout will occur
    from direct reclaim the same way as without a cpuset.

    Signed-off-by: Christoph Lameter <>
    Cc: Nick Piggin <>
    Cc: Peter Zijlstra <>
    Cc: Paul Menage <>
    Cc: Derek Fults <>
    Signed-off-by: David Rientjes <>
    mm/vmscan.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/mm/vmscan.c b/mm/vmscan.c
    --- a/mm/vmscan.c
    +++ b/mm/vmscan.c
    @@ -1604,7 +1604,8 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
    if (total_scanned > sc->swap_cluster_max +
    sc->swap_cluster_max / 2) {
    - wakeup_pdflush(laptop_mode ? 0 : total_scanned, NULL);
    + wakeup_pdflush(laptop_mode ? 0 : total_scanned,
    + &cpuset_current_mems_allowed);
    sc->may_writepage = 1;

     \ /
      Last update: 2008-10-30 20:29    [W:0.033 / U:1.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site