Messages in this thread | | | Date | Thu, 30 Oct 2008 11:01:22 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH] x86: simplify X86_MPPARSE config option |
| |
>>> Ingo Molnar <mingo@elte.hu> 30.10.08 11:51 >>> > >* Jan Beulich <jbeulich@novell.com> wrote: > >> Signed-off-by: Jan Beulich <jbeulich@novell.com> >> >> --- >> arch/x86/Kconfig | 12 ++---------- >> 1 file changed, 2 insertions(+), 10 deletions(-) >> >> --- linux-2.6.28-rc2/arch/x86/Kconfig 2008-10-30 11:03:18.000000000 +0100 >> +++ 2.6.28-rc2-x86-kconfig-cleanup/arch/x86/Kconfig 2008-10-21 13:57:07.000000000 +0200 >> @@ -235,21 +235,13 @@ config X86_FIND_SMP_CONFIG >> def_bool y >> depends on X86_MPPARSE || X86_VOYAGER >> >> -if ACPI >> config X86_MPPARSE >> - def_bool y >> - bool "Enable MPS table" >> + bool "Enable MPS table" if ACPI >> + default y >> depends on X86_LOCAL_APIC >> help >> For old smp systems that do not have proper acpi support. Newer systems >> (esp with 64bit cpus) with acpi support, MADT and DSDT will override it >> -endif >> - >> -if !ACPI >> -config X86_MPPARSE >> - def_bool y >> - depends on X86_LOCAL_APIC >> -endif > >hm, that's not an equivalent change. But i guess we can do this, it >sure looks like a cleaner construct.
Why is it not equivalent (apart from the help portion, which doesn't matter when the prompt isn't visible)?
Jan
| |