lkml.org 
[lkml]   [2008]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT

* Kirill A. Shutemov <kirill@shutemov.name> wrote:

> - /* for MAP_32BIT mappings we force the legact mmap base */
> - if (!test_thread_flag(TIF_IA32) && (flags & MAP_32BIT))
> + /* for MAP_32BIT mappings and ADDR_LIMIT_32BIT personality we force the
> + * legact mmap base
> + */

please use the customary multi-line comment style:

/*
* Comment .....
* ...... goes here:
*/
and you might use the opportunity to fix the s/legact/legacy typo as
well.

but more generally, we already have ADDR_LIMIT_3GB support on x86. Why
should support for ADDR_LIMIT_32BIT be added?

Ingo


\
 
 \ /
  Last update: 2008-10-03 10:07    [W:0.489 / U:0.380 seconds]
©2003-2011 Jasper Spaans. Advertise on this site