lkml.org 
[lkml]   [2008]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG
On Fri, 3 Oct 2008, Jiri Kosina wrote:
> On Fri, 3 Oct 2008, Linus Torvalds wrote:
>
> > > The debugging message is racy anyway with respect to accessing
> > > nvm_owner, right? It should be done after the mutex has been
> > > succesfully acquired.
> > It's done that way on purpose - to see who _could_ be racing.
>
> I know. I just wanted to point out that we probably don't want the patch
> in 2.6.27 in this form, users wouldn't like to have warning in their logs
> every time mutex is not acquired on a first attempt :)

Yeah, it should go before .27 final. It now just gathers data as
people actually care about warn_ons or they are even caught
automatically via kernel oops.

Thanks,

tglx


\
 
 \ /
  Last update: 2008-10-03 21:41    [W:0.040 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site